Skip to content

Fixes #64576 : Allow command and commandfor on button elements for In…#11483

Closed
PANawkar wants to merge 2 commits into
WordPress:trunkfrom
PANawkar:64576-local
Closed

Fixes #64576 : Allow command and commandfor on button elements for In…#11483
PANawkar wants to merge 2 commits into
WordPress:trunkfrom
PANawkar:64576-local

Conversation

@PANawkar

@PANawkar PANawkar commented Apr 9, 2026

Copy link
Copy Markdown

Allow the Invoker Commands API attributes command and commandfor on in $allowedposttags so post content sanitization (wp_kses_post()) no longer strips them. This matches existing support for popovertarget / popovertargetaction from the Popover API work (#61959).

Adds a PHPUnit test that verifies a button with command / commandfor and a popover target survives wp_kses_post().

Trac ticket: https://core.trac.wordpress.org/ticket/64576

@github-actions

github-actions Bot commented Apr 9, 2026 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @pratik.nawkar@xecurify.com.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

pento pushed a commit that referenced this pull request Jun 19, 2026
@afercia
KSES: Add command and commandfor to the list of allowed attributes fo…
e3c2654 
…r buttons.

Developed in: #11483

Props pratiknawkar94, joedolson, westonruter, afercia.

Fixes #64576.


git-svn-id: https://develop.svn.wordpress.org/trunk@62531 602fd350-edb4-49c9-b593-d223f7449a82
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62531
GitHub commit: e3c2654

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Jun 19, 2026
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Jun 19, 2026
@afercia
KSES: Add command and commandfor to the list of allowed attributes fo…
44cace8 
…r buttons.

Developed in: WordPress/wordpress-develop#11483

Props pratiknawkar94, joedolson, westonruter, afercia.

Fixes #64576.

Built from https://develop.svn.wordpress.org/trunk@62531


git-svn-id: http://core.svn.wordpress.org/trunk@61812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Webizito pushed a commit to Webizito/wordpress-develop that referenced this pull request Jun 21, 2026
@afercia @Webizito
KSES: Add command and commandfor to the list of allowed attributes fo…
601ede9 
…r buttons.

Developed in: WordPress#11483

Props pratiknawkar94, joedolson, westonruter, afercia.

Fixes #64576.


git-svn-id: https://develop.svn.wordpress.org/trunk@62531 602fd350-edb4-49c9-b593-d223f7449a82
KhushalSainS pushed a commit to KhushalSainS/wordpress-develop that referenced this pull request Jul 1, 2026
@afercia @KhushalSainS
KSES: Add command and commandfor to the list of allowed attributes fo…
34f44b8 
…r buttons.

Developed in: WordPress#11483

Props pratiknawkar94, joedolson, westonruter, afercia.

Fixes #64576.


git-svn-id: https://develop.svn.wordpress.org/trunk@62531 602fd350-edb4-49c9-b593-d223f7449a82
SteelWagstaff pushed a commit to SteelWagstaff/wordpress-develop that referenced this pull request Jul 2, 2026
@afercia @SteelWagstaff
KSES: Add command and commandfor to the list of allowed attributes fo…
0bc095a 
…r buttons.

Developed in: WordPress#11483

Props pratiknawkar94, joedolson, westonruter, afercia.

Fixes #64576.


git-svn-id: https://develop.svn.wordpress.org/trunk@62531 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PANawkar @westonruter